Change in flashrom[master]: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros - flashrom-gerrit

25 Mar 2022


      Attention is currently required from: Subrata Banik, Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62868 )
Change subject: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros
......................................................................
Patch Set 11:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62868/comment/5c9ff157_0c89b33c 
PS11, Line 1511: erase
isn't this explicitly adding a "read" which was implicit before?
Also make it clear in the commit message that this was added to be explicit over it being implicit there.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80
Gerrit-Change-Number: 62868
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Fri, 25 Mar 2022 03:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment