Attention is currently required from: Anastasia Klimchuk, David Wu, Kapil Porwal, Maximilian Brune, Nikolai Artemiev, Subrata Banik.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79088?usp=email )
Change subject: flashchips: Add GD25LQ255E
......................................................................
Patch Set 9:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/79088/comment/b3fed484_bbc55af6 :
PS9, Line 6559: FEATURE_WRSR_EXT2
Also for my education: how do I find out from datasheet that FEATURE_WRSR_EXT2 is supported? Thank y […]
Umm.. I was refer to funciton spi_prepare_wrsr_ext():
```
/*
* Writing SR2 or higher with an extended WRSR command requires
* writing all lower SRx along with it, so just read the lower
* SRx and write them back.
*/
```
If it has SR2(or higher), FEATURE_WRSR_EXT2 is needed.
But after check the code again, I think my opinion is incorrect.
Do you know how to check FEATURE_WRSR_EXT2 is supported?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I0d780255ed6772f4aa406584acf071a7ddd6da47
Gerrit-Change-Number: 79088
Gerrit-PatchSet: 9
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 19 Dec 2023 05:14:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment