David Hendricks has posted comments on this change. ( https://review.coreboot.org/22421 )
Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag
......................................................................
Patch Set 7: Code-Review+2
Seems reasonable. As you say, it doesn't introduce any problems that don't already exist. It might be useful to add a TODO or something to remind us to revisit this later on.
--
To view, visit
https://review.coreboot.org/22421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c
Gerrit-Change-Number: 22421
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jan 2018 02:43:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes