Change in flashrom[master]: layout: Introduce flashrom_layout_add_region() - flashrom-gerrit

13 May 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33517 )
Change subject: layout: Introduce flashrom_layout_add_region()
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/33517/comment/8eae4efa_437cf4f9 
PS4, Line 116: int flashrom_layout_add_region(struct flashrom_layout *, size_t start, size_t end, const char *name);
💯 no more building a flashmap and having flashrom parse that!
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/33517
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I50d473d0d5d1fb38bd6f9ae3d7127e9ea66a94e1
Gerrit-Change-Number: 33517
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Daniel Campello campello@chromium.org
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Daniel Campello campello@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 13 May 2021 23:44:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment