Attention is currently required from: Nico Huber, Rizwan Qureshi, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62251 )
Change subject: ichspi: Add Alder Lake support
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62251/comment/2e13eff3_09e0111a
PS12, Line 12: TEST=```localhost ~ # flashrom --flash-name
Any other tests, e.g. reading? If the ME region is locked, you can still read the other regions. A good test would be:
flashrom -p internal --ifd -i fd -i bios -r filename.rom
This makes use of flashrom's IFD parsing code to decide which parts of the flash chip should be read. This tests the changes to `guess_ich_chipset_from_content()`, please check the flashrom log to verify the correct chipset is detected.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62251
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie66cf519df13f3391c41f5016b16a81ef3dfd4bf
Gerrit-Change-Number: 62251
Gerrit-PatchSet: 12
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 01 Mar 2022 10:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment