[S] Change in flashrom[master]: libflashrom: Define macro to detect v1.3 header - flashrom-gerrit

28 Nov 2022


      Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70027 )
Change subject: libflashrom: Define macro to detect v1.3 header
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
I'm not against doing it this way, but I'm wondering how this gets used. […]
Heres what SDL does,
https://github.com/libsdl-org/SDL/blob/main/include/SDL3/SDL_version.h#L64
`#define SDL_MAJOR_VERSION   3`
and as a struct:
`typedef struct SDL_version`
and as a runtime function
`extern DECLSPEC void SDLCALL SDL_GetVersion(SDL_version * ver);`
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/70027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iac35ff167272e1bc3d5434f7b47099f53bfceab7
Gerrit-Change-Number: 70027
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Evan Benn evanbenn@google.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 28 Nov 2022 22:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Evan Benn evanbenn@google.com
Gerrit-MessageType: comment