Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Martin L Roth, Peter Marheine, Stefan Reinauer, Thomas Heijligen.
Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76455?usp=email )
Change subject: doc: Add code of conduct ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I would like to suggest that the previous Friendliness etiquette has not worked very well in the past.
That may be the case, but then again it worked with conflicts bigger than the one which caused explosions two months ago.
Particularly if I compare the coreboot project and the flashrom project, I have clear indication that there is value in adopting the coreboot Code of Conduct over the current "Friendliness" page. The developer base and community of both projects are fairly similar, with the coreboot project being significantly larger (and thus having more potential for conflict). I have gotten feedback that people generally prefer the coreboot Code of conduct implementation, and also the clarity of not trying to hide a Code of conduct behind the ambiguous term "Friendliness".
Thank you for the feedback. I think there are significant overlaps betwen the two communities, but also quite some differences. For example, Anastasia seems to be only active in the flashrom gerrit and flashrom mailing list, but not on the coreboot side. Some other people who were previously very active in flashrom were only marginally active in coreboot.
Is the feedback you got also available somewhere in public? I think it would be good to have this whole discussion on the mailing list.
So, there is both a need and an update already available.
There may be a need for change, but even if we treat it as a source code patch, the submitter would have to list the bugs fixed by the new code. Wholesale replacements of source files rarely happen.
A set of bylaws, rules or code of conduct shapes a whole community and has an impact far beyond a source code patch that can be easily reverted. Due to that, we should IMHO tread way more carefully here.
The "update available" is something which may have worked for coreboot (I do not have enough info to make any assessment about that), but will it work for flashrom?
I would like to understand which parts of the coreboot code of conduct you oppose to with your -2, as there is a general expectation that -2 blocks give more actionable feedback than "I don't like change".
Actionable feedback: 1. Acknowledge that rules already exist 2. Commit the existing rules to the repo of the new website 3. Propose changes with a justification (currently missing) 4. For wide-reaching changes like this, involve the community more than two lines in the meeting notes and a patch in gerrit, preferably with an (archivable) mailing list discussion
5. I think my personal concerns with the coreboot code of conduct were witten down as mailing list posts on the coreboot mailing list back when we had the coreboot code of conduct discussions. Some of them were addressed, some weren't. I can dig them up again if you want.
My personal concerns with the coreboot code of conduct are independent of the process here, though. With the coreboot code of conduct, we had a proper mailing list discussion addressing actionable feedback items 1-4 from above. We also gave people enough time to respond and catch up.
I do like change. I am also very much in favour of reviewing changes to make sure each part of the change is a net improvement instead of discard+rewrite. That is a hard lesson I learned from coreboot v3 and (besides feedback items 1-4) the reason I voted -2.
From the perspective of being legally responsible for running the infrastructure of this project, I also have a strong interest in unifying how the projects running on this infrastructure are generally managed.
That is definitely a valid point, and we should address that. Maybe by working with SFC/SPI or a similar body?
That said, it is good to have you back, Carl-Daniel. Welcome to your first review in 3.5 years (and 5th review since flashrom switched to gerrit!) I am sure we will find a good solution that fits everybody's needs to some extent.
Thank you!
-
Carl-Daniel Hailfinger (Code Review)