Attention is currently required from: Nico Huber, Thomas Heijligen, Paul Menzel. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS1:
I've started working on an overhaul of the hwaccess code in CB:61275 and CB:61276. […]
61276 in particular looks like a nice cleanup of these headers. Fixing the build regression seems like the important aspect of this change, and calling it a temporary solution until the headers are cleaned up more comprehensively sounds fine to me.
File hwaccess_x86_io.h:
https://review.coreboot.org/c/flashrom/+/61194/comment/3796a02d_fc2baee8 PS4, Line 41: #define HAVE_RGET_IO_PERMS 1
not needed
Done
File internal.c:
https://review.coreboot.org/c/flashrom/+/61194/comment/4343a592_6843769f PS4, Line 245: if (rget_io_perms()) {
You can move this under the x86 guard at line 275. […]
Done
-
Peter Marheine (Code Review)