Attention is currently required from: Peter Marheine. Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64849 )
Change subject: flashrom_tester: Use Flashrom trait instead of struct FlashromCmd ......................................................................
Patch Set 1:
(1 comment)
File util/flashrom_tester/src/tester.rs:
https://review.coreboot.org/c/flashrom/+/64849/comment/1a9ea5a3_3e22d98e PS1, Line 55: pub cmd: &'a dyn Flashrom, The other option suggested by Peter is to take ownership here, with `pub cmd: Box<dyn Flashrom>`
I had a go at this. I'm not expert in rust enough to make it work; many changes to the WriteProtectState lifetime annotations and 'Sized' trait compilation errors make it tricky.