Attention is currently required from: Felix Singer, Alex Badea.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73037 )
Change subject: asm106x: add programmer for ASM106x SATA controllers ......................................................................
Patch Set 7:
(9 comments)
Patchset:
PS7: only very minor things but otherwise looks great, thanks for the contribution!
File asm106x.c:
https://review.coreboot.org/c/flashrom/+/73037/comment/5b478fe6_c309da8c PS7, Line 76: u const
https://review.coreboot.org/c/flashrom/+/73037/comment/5b5f8d75_698024dd PS7, Line 79: int unsigned int?
https://review.coreboot.org/c/flashrom/+/73037/comment/a8c0bf7d_3aa20719 PS7, Line 91: u const
https://review.coreboot.org/c/flashrom/+/73037/comment/1e2c46ac_f87ab73c PS7, Line 92: uint32_t val; drop forward decl
https://review.coreboot.org/c/flashrom/+/73037/comment/91b20ccd_02fc665f PS7, Line 98: v uint32_t val = ..
https://review.coreboot.org/c/flashrom/+/73037/comment/b6e20c98_8132ec33 PS7, Line 100: unsigned unsigned int
https://review.coreboot.org/c/flashrom/+/73037/comment/db2f87d4_6cb55bba PS7, Line 129: .write_aai = default_spi_write_aai, delete.
https://review.coreboot.org/c/flashrom/+/73037/comment/c2055d8f_3e625882 PS7, Line 149: (void *) cast shouldn't be required?
-
Edward O'Callaghan (Code Review)