Attention is currently required from: Felix Singer, roman.stingler@gmail.com. Vasily Galkin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63910 )
Change subject: flashchips: Add IS25WQ040 ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1: I used flashrom to flash the IS25WQ040 and initially started with this patch.
During flasing I found that the IC size in the patch is specified incorrectly. According to docs and in practice - it is 4096 KiBits, not 4096 KiBytes.
So the size in this patch is specified in correctly. I'd fixed this, perform testing and created https://review.coreboot.org/c/flashrom/+/58179 (it is still not merged).
Unfortunately I didn't crosslinked it form github, and this was created as a duplicate...
So, I think that https://review.coreboot.org/c/flashrom/+/58179 should be merged instead of this, since here the size is incorrect.