Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase - flashrom-gerrit

10 Jan 2021


      Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 )
Change subject: bitbang-spi.c: support clock polarity and phase
......................................................................
Patch Set 10:
(2 comments)
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/49255/comment/bc863fec_34e1ce19 
PS9, Line 77: }
...
sorry, I mean the `\n` deletion after the closing '}' is spurious here.
Done
https://review.coreboot.org/c/flashrom/+/49255/comment/8b9166db_2302c553 
PS9, Line 140:
...
maybe put this style change into https://review.coreboot. […]
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/49255
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04c1dfe132d756119229b27c3cd611d1be1abc8d
Gerrit-Change-Number: 49255
Gerrit-PatchSet: 10
Gerrit-Owner: Xiang Wang merle@hardenedlinux.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Shawn C citypw@hardenedlinux.org
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 10 Jan 2021 06:22:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment