Hello Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/44811
to review the following change.
Change subject: dediprog: Add 4BA support on SF600 protocol version 3 ......................................................................
dediprog: Add 4BA support on SF600 protocol version 3
Tested on SF600 protocol 3 V:7.2.45 Fixes the error message: "4-byte address requested but master can't handle 4-byte addresses."
Change-Id: I2d91f940eb246b928a9d386eefb4195f9ccf1bb5 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M dediprog.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/44811/1
diff --git a/dediprog.c b/dediprog.c index b847db4..6e3f098 100644 --- a/dediprog.c +++ b/dediprog.c @@ -1272,7 +1272,7 @@ (dediprog_devicetype == DEV_SF600 && protocol() == PROTOCOL_V3)) spi_master_dediprog.features &= ~SPI_MASTER_NO_4BA_MODES;
- if (protocol() == PROTOCOL_V2) + if (protocol() >= PROTOCOL_V2) spi_master_dediprog.features |= SPI_MASTER_4BA;
if (register_spi_master(&spi_master_dediprog) || dediprog_set_leds(LED_NONE))
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44811 )
Change subject: dediprog: Add 4BA support on SF600 protocol version 3 ......................................................................
Patch Set 1: Code-Review+1
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44811 )
Change subject: dediprog: Add 4BA support on SF600 protocol version 3 ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/44811 )
Change subject: dediprog: Add 4BA support on SF600 protocol version 3 ......................................................................
dediprog: Add 4BA support on SF600 protocol version 3
Tested on SF600 protocol 3 V:7.2.45 Fixes the error message: "4-byte address requested but master can't handle 4-byte addresses."
Change-Id: I2d91f940eb246b928a9d386eefb4195f9ccf1bb5 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/44811 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: David Hendricks david.hendricks@gmail.com --- M dediprog.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Arthur Heymans: Looks good to me, but someone else must approve
diff --git a/dediprog.c b/dediprog.c index ac7d462..4f48f47 100644 --- a/dediprog.c +++ b/dediprog.c @@ -1271,7 +1271,7 @@ (dediprog_devicetype == DEV_SF600 && protocol() == PROTOCOL_V3)) spi_master_dediprog.features &= ~SPI_MASTER_NO_4BA_MODES;
- if (protocol() == PROTOCOL_V2) + if (protocol() >= PROTOCOL_V2) spi_master_dediprog.features |= SPI_MASTER_4BA;
if (register_spi_master(&spi_master_dediprog) || dediprog_set_leds(LED_NONE))
-
Arthur Heymans (Code Review) -
David Hendricks (Code Review)
-
Nico Huber (Code Review)
-
Patrick Rudolph (Code Review)