Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62282 )
Change subject: ichspi: Add Jasper Lake support ......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS4:
Unresolving then because it does look like a pch300 although I am not 100% on every tiny idiosyncr […]
You are right `NM` is confusing, can we comment it better? Possibly copy what you just said there near verbatim into the `ich_number_of_masters()` function?
OK, I picked to follow pch300 in `prettyprint_ich_descriptor_master()` and fixed that up. `ich_number_of_masters()` was left untouched.
I wonder how much of this declarative information about the differences could be encoded into just a big table instead of scattered over heaps of switch statements in the control flow itself? A lot of it doesn't seem dynamic just XXX has 3 and YYY has 4 of "thing".
Resolved?
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62282/comment/62044ba6_c49c4d9d PS8, Line 1061: CHIPSET_ELKHART_LAKE
Google should have access too. Since ~SKL, both the SPI guide and FIT are […]
Long story about the access ACL's there.. Can talk out of band about it || summarised as 'a lot of nonsense'.