Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/70893 )
Change subject: layout: Rename find_romentry() -> romentry_exists() ......................................................................
layout: Rename find_romentry() -> romentry_exists()
The functions purpose is to test for existence not to actually return the entry, therefore rename accordingly.
Change-Id: Ibf14357c00717d1a7b6bc9c83e797fac125559c4 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M layout.c 1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/70893/1
diff --git a/layout.c b/layout.c index 1206b59..f2973d1 100644 --- a/layout.c +++ b/layout.c @@ -209,7 +209,7 @@ }
/* returns -1 if an entry is not found, 0 if found. */ -static int find_romentry(struct flashrom_layout *const l, char *name, char *file) +static int romentry_exists(struct flashrom_layout *const l, char *name, char *file) { if (!l->head) return -1; @@ -244,7 +244,7 @@
tmp = args; while (tmp) { - if (find_romentry(l, tmp->name, tmp->file) < 0) { + if (romentry_exists(l, tmp->name, tmp->file) < 0) { msg_gerr("Invalid region specified: "%s".\n", tmp->name); return 1;