Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive - flashrom-gerrit

10 Feb 2018


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23678 )
Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive
......................................................................
Patch Set 5:
(1 comment)
...
(5 comments)
Hmmm, I'll sleep over it. Don't like the possibility to specify
a conflicting layout file by accident without noticing.
This is already a problem if 2 homonymous but different entries exist in a layout file...
https://review.coreboot.org/#/c/23678/1/libflashrom.c
File libflashrom.c:
https://review.coreboot.org/#/c/23678/1/libflashrom.c@377
PS1, Line 377:
...
Overflow check? I guess it's impossible without knowing that […]
Using an append function like in 23353 could do it?
-- 
To view, visit https://review.coreboot.org/23678
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13
Gerrit-Change-Number: 23678
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 10 Feb 2018 00:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No