Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )
Change subject: [WIP] meson: rework the programmer selection ......................................................................
Patch Set 11:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63724/comment/2bcc7f59_1d823168 PS7, Line 12: get mandetory
get mandetory -> gets mandatory
Done
https://review.coreboot.org/c/flashrom/+/63724/comment/f624dc41_c70bf933 PS7, Line 20: get's selectet
get's selectet -> gets selected
Done
https://review.coreboot.org/c/flashrom/+/63724/comment/473c11be_ec3444f3 PS7, Line 21: determin
determin -> determine
Done
File meson.build:
https://review.coreboot.org/c/flashrom/+/63724/comment/8f5c60cc_208f4578 PS7, Line 109: get edded
does it mean "gets added"?
Done
File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/63724/comment/a7a6b9b2_1d243c1b PS7, Line 9: 'atahpt', 'atapromise', 'buspirate_spi', 'ch341a_spi', 'dediprog', 'developerbox_spi', : 'digilent_spi', 'jlink_spi', 'drkaiser', 'dummy', 'ft2232_spi', 'gfxnvidia', 'raiden_debug_spi', : 'internal', 'it8212', 'linux_mtd', 'linux_spi', 'mstarddc_spi', 'nic3com', 'nicintel_eeprom', : 'nicintel', 'nicintel_spi', 'nicnatsemi', 'nicrealtek', 'ogp_spi', 'pickit2_spi', 'pony_spi', : 'rayer_spi', 'satamv', 'satasii', 'serprog', 'usbblaster_spi', 'stlinkv3_spi', : 'lspcon_i2c_spi', 'mediatek_i2c_spi', 'realtek_mst_i2c_spi',
For the list of individual programmers, do you think maybe we can order them alphabetically? It wasn […]
Yes, I just haven't done it yet.
-
Thomas Heijligen (Code Review)