Attention is currently required from: Nico Huber, powpowd@gmail.com.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62061 )
Change subject: meson.build: Don't depend on getrevision.sh
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/62061/comment/88c3ffb6_c858c2cf
PS3, Line 2: version : run_command('util/getversion.sh', '--version').stdout().strip(),
Is this change intentional?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62061
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id8601155b35f0299200c27d0278606127410ff16
Gerrit-Change-Number: 62061
Gerrit-PatchSet: 3
Gerrit-Owner: powpowd@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: powpowd@gmail.com
Gerrit-Comment-Date: Thu, 17 Feb 2022 14:55:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment