Attention is currently required from: ChrisEric1 CECL.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB controller flashing
......................................................................
Patch Set 23: -Code-Review
(1 comment)
Patchset:
PS23:
I found the problem with your chip. The code fails when readcnt != 4
That's the reason why it only recognize your chip with the RDID4 patch.
I'll have a deeper look into the flashing process.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 23
Gerrit-Owner: ChrisEric1 CECL
christopherericlentocha@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: ChrisEric1 CECL
christopherericlentocha@gmail.com
Gerrit-Comment-Date: Wed, 22 Feb 2023 13:35:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment