Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email )
Change subject: cli_classic: Add rpmc command support ......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3: I didn't have my editor set up correctly for this coding style. Now with 8-wide tabs, I have restored the things i retabbed back to their original state. Also I adjusted my patch to better match the coding style. Please let me know if there are more things that need adjustment to match the coding style.
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/84840/comment/d479cedd_bfd3983e?usp... : PS2, Line 113:
I don't think we should re-tab all this text, since at default 8-char tabs some of them now exceed 8 […]
Done
https://review.coreboot.org/c/flashrom/+/84840/comment/00d2d6d8_8a91fa90?usp... : PS2, Line 147: #if CONFIG_RPMC_ENABLED == 1
These options are all related to RPMC, so adding a heading might be useful. […]
Done
-
Matti Finder (Code Review)