Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46481 )
Change subject: spi25.c: Replace tab with space after '=' symbol ......................................................................
spi25.c: Replace tab with space after '=' symbol
Trivial, only noticed while diff'ing with ChromiumOS fork.
Change-Id: I247d9cb1910a9afdb0e7bfe81515d51514da6550 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M spi25.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/46481/1
diff --git a/spi25.c b/spi25.c index a044e02..dd4543d 100644 --- a/spi25.c +++ b/spi25.c @@ -649,7 +649,7 @@ int spi_nbyte_read(struct flashctx *flash, unsigned int address, uint8_t *bytes, unsigned int len) { - const bool native_4ba = flash->chip->feature_bits & FEATURE_4BA_READ && spi_master_4ba(flash); + const bool native_4ba = flash->chip->feature_bits & FEATURE_4BA_READ && spi_master_4ba(flash); uint8_t cmd[1 + JEDEC_MAX_ADDR_LEN] = { native_4ba ? JEDEC_READ_4BA : JEDEC_READ, };
const int addr_len = spi_prepare_address(flash, cmd, native_4ba, address);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46481 )
Change subject: spi25.c: Replace tab with space after '=' symbol ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/46481 )
Change subject: spi25.c: Replace tab with space after '=' symbol ......................................................................
spi25.c: Replace tab with space after '=' symbol
Trivial, only noticed while diff'ing with ChromiumOS fork.
Change-Id: I247d9cb1910a9afdb0e7bfe81515d51514da6550 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/46481 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M spi25.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/spi25.c b/spi25.c index a044e02..dd4543d 100644 --- a/spi25.c +++ b/spi25.c @@ -649,7 +649,7 @@ int spi_nbyte_read(struct flashctx *flash, unsigned int address, uint8_t *bytes, unsigned int len) { - const bool native_4ba = flash->chip->feature_bits & FEATURE_4BA_READ && spi_master_4ba(flash); + const bool native_4ba = flash->chip->feature_bits & FEATURE_4BA_READ && spi_master_4ba(flash); uint8_t cmd[1 + JEDEC_MAX_ADDR_LEN] = { native_4ba ? JEDEC_READ_4BA : JEDEC_READ, };
const int addr_len = spi_prepare_address(flash, cmd, native_4ba, address);
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)