Attention is currently required from: Evan Benn, Hsuan-ting Chen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79304?usp=email )
Change subject: flashrom_tester: Fix partial_lock_test on libflashrom
......................................................................
Patch Set 2:
(1 comment)
File util/flashrom_tester/flashrom/src/flashromlib.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/987896eb_ee8796fa :
PS1, Line 200: .flag_set(FlashromFlag::FlashromFlagSkipUnreadableRegions, true);
Those should be CrOS only default value. […]
These two are to handle the case of the CSME locking parts of flash. They are therefore outside the scope of a default value for the flags type so should be set explicitly with a comment about why.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79304?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7a8ac0c0984fef3cd9e73ed8d8097ddf429e54b2
Gerrit-Change-Number: 79304
Gerrit-PatchSet: 2
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Evan Benn
evanbenn@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-CC: Nikolai Artemiev
nartemiev@chromium.org
Gerrit-Attention: Evan Benn
evanbenn@gmail.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Comment-Date: Wed, 13 Dec 2023 03:40:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evan Benn
evanbenn@gmail.com
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Gerrit-MessageType: comment