Change in flashrom[master]: ft2232_spi.c: Implement spi_send_multicommand() - flashrom-gerrit

25 Jun 2021


      Attention is currently required from: Simon Buhrow, Alan Green, Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Samir Ibradžić.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Implement spi_send_multicommand()
......................................................................
Patch Set 35: Code-Review+1
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/comment/83b434dc_dadf3f44 
PS34, Line 317:
...
Generally right, but it's mimicking the original code and that will […]
Ack
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 35
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Samir Ibradžić sibradzic@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Alan Green avg@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Samir Ibradžić sibradzic@gmail.com
Gerrit-Comment-Date: Fri, 25 Jun 2021 12:01:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment