[M] Change in flashrom[master]: opaque: make opaque programmers expose register read/write capability - flashrom-gerrit

16 Jan 2023


      Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66032 )
Change subject: opaque: make opaque programmers expose register read/write capability
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/66032/comment/9b8003bb_86c55cd5 
PS2, Line 231: 	 * TODO: check if the programmer supports writing the register that the
             : 	 * bit is in. For example, some chipsets may only allow SR1 to be
             : 	 * written.
...
maybe keep the comment just slightly reworded.
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66032
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9ec34a8d6f55a76f890e0066d0b896560331ede0
Gerrit-Change-Number: 66032
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 17 Jan 2023 02:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment