Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58735 )
Change subject: ichspi: Split very long init function into two ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I want to talk more about this patch. Yes it splits init function into two: init_ich7_spi and init_ich_default. However another thing here is: initialisation of hwseq and swseq that used to happen in the beginning of init function now moved to init_ich_default. I did this after staring at the code for a while, the code looks like hwseq and swseq are only used for chipsets served by init_ich_default. I could make a mistake, because both hwseq and swseq are global state (global state that I hope to remove one day), global state makes it harder to read the code and understand what is used where.
This chain is hanging for so long (sorry) because I am trying to find devices to test older chipsets which are served by init_ich7_spi. If anyone here knows that hwseq and swseq are actually used for chipsets on init_ich7_spi, please tell me (thanks!!), this would mean I made a mistake and need to fix this patch.
Now that I look at my own comment, I see that commit message should be updated. Leaving this comment unresolved for this.
-
Anastasia Klimchuk (Code Review)