Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev.
David Hendricks has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/82649?usp=email )
Change subject: doc: Convert ME and Intel docs
......................................................................
Patch Set 1:
(1 comment)
File doc/user_docs/management_engine.rst:
PS1:
Does the coding style guidelines apply to documentation as well? […]
Good points. I'd vote for 112 columns to go along with the coding guidelines, though the coding guideline itself seems to go with 120 columns so maybe that's better :-) Anyway, pick *something* that can be auto-enforced to keep the docs uniformly formatted and help any newcomers who might want to contribute to the docs (PRs from Github tended to violate all kinds of style rules, IIRC).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82649?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I79af5674f3af9ca880e89becd6a272a2cf8ed599
Gerrit-Change-Number: 82649
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 03 Jun 2024 21:17:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org