Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63606 )
Change subject: meson: Add optimisation level s into meson build
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Does the resulting binary change?
Yes and... I am confused.
First of all, size of the binary grew bigger after this patch. But optimisation level s means optimizing for size?
Also this is the first time I looked into the size of binary that meson produces. And it is almost twice bigger than what make produces?
I don't understand why is that, maybe I am doing something wrong?
I was running:
make clean && make CONFIG_EVERYTHING=yes
and also just running
ninja
ninja test
and picking what was generated in meson build directory.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63606
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4ca96a866529cac320e66516ef280d5100ceefab
Gerrit-Change-Number: 63606
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 05:27:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment