Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Deomid "rojer" Ryabkov, Tim Chu.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 )
Change subject: Revert "Add support for Intel Emmitsburg PCH"
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
The patch was reviewed and tested by multiple parties - you were one of them! Your comments didn […]
Hi David,
I think there is a bit of cross talking here.
David => Nico is correct that we should revert and re-land with it fixed correctly. Obviously the breakage wasn't intentional and communication was got lost there with Nico's unanswered question. Let's just let the revert go though please, please remember commits are just hashes and are free we don't need to fight over this and we can re-land this once you addressed all the comments in a follow up patch that fixes the concerns. 😊
Nico => It is sufficient to say revert-first upon breakage, you are absolutely right there. Just no need to threaten forkage whenever someone makes a mistake, I would imagine David does care about your concern already. Your technical arguments are sufficient on their own merit they just need to be understood by the reader. I think what happened here is that you can see something obvious to you but not obvious to David. Let's be patient and care about one another as humans first.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57589
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a
Gerrit-Change-Number: 57589
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: David Hendricks
Gerrit-Attention: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 14 Sep 2021 02:06:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment