Change in flashrom[master]: programmer.h: Convert anon union to anon struct
Attention is currently required from: Sam McNally, Stefan Reinauer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50246 ) Change subject: programmer.h: Convert anon union to anon struct ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/50246/comment/6e0de756_650c5f98 PS2, Line 29: printf("%d\n", *foo.b); I just removed it to avoid confusion.
Still, I believe this change is a good idea: it's better to have null pointers than non-null but invalid pointers.
Indeed that's the idea. File programmer.h: https://review.coreboot.org/c/flashrom/+/50246/comment/78e8b15e_4ac8fed1 PS2, Line 752: struct {
This will need corresponding updates to ensure unused masters are zeroed out. Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/50246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I576967a8599b923c902e39f177f39146291cc242 Gerrit-Change-Number: 50246 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Alan Green <avg@google.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Sam McNally <sammc@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Sam McNally <sammc@google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Mon, 03 May 2021 04:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally <sammc@google.com> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Edward O'Callaghan (Code Review)