Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/49270 )
Change subject: bitbang_spi.c: Do not set MOSI during initialization ......................................................................
bitbang_spi.c: Do not set MOSI during initialization
With CS# deasserted, the value is ignored. Ensuring SCK is in the idle state is enough here. This is necessary because setting MOSI will assert SCK with CPHA=1, which is implemented in subsequent commits.
Change-Id: I925d0ae55ae006dfcc6e7fb90364235526c576ef Signed-off-by: Angel Pons th3fanbus@gmail.com --- M bitbang_spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/49270/1
diff --git a/bitbang_spi.c b/bitbang_spi.c index dfcf503..00c631f 100644 --- a/bitbang_spi.c +++ b/bitbang_spi.c @@ -151,7 +151,7 @@ /* Only mess with the bus if we're sure nobody else uses it. */ bitbang_spi_request_bus(master); bitbang_spi_set_cs(master, 1); - bitbang_spi_set_mosi_set_sck(master, 0, 0); + bitbang_spi_set_sck(master, 0); /* FIXME: Release SPI bus here and request it again for each command or * don't release it now and only release it on programmer shutdown? */