Attention is currently required from: PoroCYon, Thomas Heijligen, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73582 )
Change subject: flashchips: Add Macronix MX25V4035F support
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73582/comment/74501ef3_54726f34
PS2, Line 17: PoroCYon
This Guidelines should receive an update based on newer developments and clarifications in the linux […]
Oh that's a good call, thanks for the link! I didn't know :)
I updated our dev guidelines (you can click the link in my first comment).
I am marking this comment (and ones in the other patches) as resolved.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73582
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8b26926c354b840ca7b14b4c5cb000e3c02f5137
Gerrit-Change-Number: 73582
Gerrit-PatchSet: 2
Gerrit-Owner: PoroCYon
p@pcy.be
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: PoroCYon
p@pcy.be
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 23 Mar 2023 06:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment