Attention is currently required from: Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 )
Change subject: cli_classic: include a fallback inplementation of getopt ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73102/comment/89ddf214_21205897 PS1, Line 7: .
nit: no period in commit summary
Done
File cli_getopt.c:
PS1:
No license?
Done
https://review.coreboot.org/c/flashrom/+/73102/comment/adace69c_57c5d6be PS1, Line 13: #if 0
Yea, this should be replaces by flashroms error message.
I'm not yet sure how exactly handle this. I don't want to use the msg_** form flash.h. The cli should not use the print infrastructure form the library