Attention is currently required from: Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69130 )
Change subject: tests: ensure chip erase operation is executed ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69130/comment/e5843999_2310a8f9 PS1, Line 18: exectued exectued -> executed (typo)
https://review.coreboot.org/c/flashrom/+/69130/comment/aa4d1430_795fa99d PS1, Line 18: (hopefully) "and is expected to fail"
Patchset:
PS1: Thanks for the patch. Very good timing!
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/69130/comment/13da1304_8665acb7 PS1, Line 159: #define UNERASED_VALUE(flash) Will this ever be needed outside of tests? If not, we have tests/include/test.h for this kind of macros. Also please add comment, even a short one, if you move to tests/include/test.h. Thanks!