Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56822 )
Change subject: linux_mtd: Free param right after its last usage
......................................................................
Patch Set 1:
(1 comment)
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/56822/comment/bc8861d5_bd6999ca
PS1, Line 401: if (param)
: msg_perr("%s does not exist\n", sysfs_path);
: else
: msg_pdbg("%s does not exist\n", sysfs_path);
suspicious, both branches are equal?
Yeah almost equal, it is error message vs debug message (msg_perr vs msg_pdbg). I read the comment above (lines 390-394) and it seems to confirm the logic is WAI, it says "print an error or print a debug message; bail out in either case".
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I126a8d06297ef4d42bc93a73f7067ccc1352d1e9
Gerrit-Change-Number: 56822
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 06 Aug 2021 00:19:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment