[L] Change in flashrom[main]: cli_classic: Add rpmc command support - flashrom-gerrit

25 Oct 2024


      Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email )
Change subject: cli_classic: Add rpmc command support
......................................................................
Patch Set 3:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/84840/comment/8709319f_bb0f0e83?usp... :
PS2, Line 159: 	printf(".\n\nYou can specify one of -h, -R, -L, "
...
Should this list be extended, since any RPMC command is also allowed?
Do you think the way I extended it is ok. Otherwise I think the message would get too long. The wp-range options are also not specified here.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/84840?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1
Gerrit-Change-Number: 84840
Gerrit-PatchSet: 3
Gerrit-Owner: Matti Finder matti.finder@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 25 Oct 2024 14:41:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine pmarheine@chromium.org