Change in flashrom[master]: build: Remove cli_classic need for internal symbols - flashrom-gerrit

19 Apr 2022


      Attention is currently required from: Edward O'Callaghan.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60074 )
Change subject: build: Remove cli_classic need for internal symbols
......................................................................
Patch Set 9: Code-Review-1
(1 comment)
Patchset:
PS9: 
`cli_classic` still needs the internal symbols of `libflashrom`. But we can use the static library to link against. Unit `cli_classic` uses only the `libflashrom.h` interface it's still a long way to go.
The code changes and commit message are unrelated to each other.
Yes, we could remove `flashrom.c` there. It's also part of `srcs`.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/60074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib04293c14f53c8e798c7d3e35483067520668161
Gerrit-Change-Number: 60074
Gerrit-PatchSet: 9
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 19 Apr 2022 16:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment