Attention is currently required from: Nico Huber, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59372 )
Change subject: flashrom.c: Validate before allocate in verify_range()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Sorry for delay, this is nice and useful patch! I should have looked long time ago, but I got buried under heaps of other stuff :(
If you could run this from command line once, that would be great. On the other hand, successful path of erase operation has a unit test.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59372
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iae886f203d1c59ae9a89421f7483a4ec3f747256
Gerrit-Change-Number: 59372
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Mon, 13 Dec 2021 22:44:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment