Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59050 )
Change subject: Makefile: Make pkg-config mandatory to find libpci ......................................................................
Patch Set 15: Code-Review+1
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/59050/comment/740bae06_48f34f9e PS15, Line 866: USE_X86_MSR := $(if $(call filter_deps,$(DEPENDS_ON_X86_MSR)),yes,no) Is this split done intentionally in this patch? or did it sneak into the rebase? Risking to state the obvious: I'd prefer a separate patch ;)
If it needs to be in this patch, the commit message should cover it. There is also an important message: we don't imply anymore that libpci requires raw access (AFAICS).
https://review.coreboot.org/c/flashrom/+/59050/comment/d6b5c72e_baebba42 PS15, Line 882: $(filter yes, $(USE_X86_MSR) $(USE_X86_PORT_IO) $(USE_RAW_MEM_ACCESS))) `$(filter )` picks words from the second argument, kind of the haystack. So this could result in multiple `yes` and then the `ifeq` wouldn't match anymore. You can turn the arguments around:
$(filter $(USE_X86_MSR) $(USE_X86_PORT_IO) $(USE_RAW_MEM_ACCESS), yes)
This can only return one `yes` because there is only one in the haystack to find.
-
Nico Huber (Code Review)