Attention is currently required from: Sam McNally, Thomas Heijligen, Edward O'Callaghan.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73286 )
Change subject: libflashrom: Provide flashrom_flash_getinfo() API
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/73286/comment/a73251c4_109dff84
PS7, Line 258: info->vendor = flashctx->chip->vendor;
Can we share the copy implementation with `flashrom_supported_flash_chips()`?
+1
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3dc32e261e6d54230d93f06b91f723811792112a
Gerrit-Change-Number: 73286
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Wed, 19 Apr 2023 06:28:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sam McNally
sammc@google.com
Gerrit-MessageType: comment