Attention is currently required from: Nico Huber, Angel Pons. powpowd@gmail.com has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62061 )
Change subject: meson.build: Don't depend on getrevision.sh ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62061/comment/36a72645_d405ae90 PS3, Line 9: (including : GitHub's auto-generated tarballs and ZIPs)
Why would anyone use those? We have signed release tarballs (e.g. https://www.flashrom. […]
(Excuse the delay; I wrote these comments immediately, but apparently they were only posted under a private “draft” status!)
I found myself in a situation where I used them recently. In fact, until yesterday, MSYS2's Flashrom package (https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-flashrom) used the GitHub tarball. It's useful on systems where you'd rather not depend on Git, but want to give people the ability to build a non-stable commit: currently, I use them in a PKGBUILD to be able to easily fetch and build the latest commit on Windows.
Either way, this is actually broken for a potential release tarball as well: even *if* versioninfo.inc is present, the build breaks if getrevision.sh isn't present – so this change is actually needed for the eventual next release.
Patchset:
PS3: Ready to finish reviewing! I didn't know whether to check the “resolved” box myself on the comments or to let you do it, so I decided to err on the side of caution.
File meson.build:
https://review.coreboot.org/c/flashrom/+/62061/comment/671f5e2b_1dbd2625 PS3, Line 2: version : run_command('util/getversion.sh', '--version').stdout().strip(),
Is this change intentional?
It's intentional, yes! It makes no functional difference, but is a bit more readable.
-
Name of user not set (Code Review)