Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk.
Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
Change subject: libflashrom: Update the API for progress callback ......................................................................
Patch Set 1:
(1 comment)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86031/comment/e2721600_738a07fa?usp... : PS1, Line 93: __attribute__((deprecated("Use flashrom_set_progress_callback_v1 instead"))); This might need some preprocessor guards for platforms where the compiler doesn't support this attribute. Looks like gcc added support for this [around 2009](https://gcc.gnu.org/pipermail/gcc-patches/2009-May/261308.html), but there are probably still some platforms we support where the usual compilers don't understand this.
Apparently `[[deprecated]]` is standard since C23 as well, but is probably much too new to use right now.