Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59921 )
Change subject: flashrom.c: extract operation only uses layout files ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59921/comment/dda8f4a7_287084ff PS1, Line 9: Extract : operation reads the layout regions to filenames with equal name to the : specified layout regions.
Do you mean to say - […]
Done
https://review.coreboot.org/c/flashrom/+/59921/comment/077e9430_f0401249 PS1, Line 16: Change-Id: Ibc9a4e2966385863345f06662521d6d0e4685121
BUG=/TEST= are useful.
Done
https://review.coreboot.org/c/flashrom/+/59921/comment/6380cea9_d537b437 PS1, Line 16: C
upstream needs a sign-off line
Done
Patchset:
PS1:
Thanks for the patch!
No problem! :)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/59921/comment/3b6e3dea_7791f99c PS1, Line 1076: read_flash_to_file(
as this relates, could you take a look at https://review.coreboot. […]
Looks good to me!! :)
-
Daniel Campello (Code Review)