Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: Add unit test to run init/shutdown for enabled drivers ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: This now has mocks in a separate compilation unit, thanks Nico and cmocka for inspiration.
This is rebased on the top of memory checks from here https://review.coreboot.org/c/flashrom/+/51243 and everything works together nicely. Dummy has been discovered to leak memory on shutdown, so memory checks works.
The patch is obviously too big and I will split it into three (one for each driver). But before splitting if you could tell me what do you think? Particularly about splitting hwaccess.h , is it an acceptable way to do it?
-
Anastasia Klimchuk (Code Review)