Change in flashrom[master]: stlinkv3_spi.c: Refactor singleton states into reentrant pattern
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54042 )
Change subject: stlinkv3_spi.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 2:
(4 comments)
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/54042/comment/c6ac430c_2d3abdac PS1, Line 451: const
I've tried to fix this for good in CB:54066.
Yes that was a good idea! Pars and opaques left to be submitted, and all tree will be covered.
https://review.coreboot.org/c/flashrom/+/54042/comment/c712ffcc_af484b1c PS1, Line 351: struct stlinkv3_spi_data *stlinkv3_data = flash->mst->spi.data;
Adding a pointer for the handle would reduce some boilerplate below […]
Yes, true, and this is the second time you give me this advice, thank you for patience. I need to remember to use this approach for future.
https://review.coreboot.org/c/flashrom/+/54042/comment/8e36c769_90a1f15f PS1, Line 528: return -1;
yeah, it's easy to fix
I didn't switch the order, but error paths should look better now after CB:54190.
https://review.coreboot.org/c/flashrom/+/54042/comment/fb65e8dc_2e8bc800 PS1, Line 533: stlinkv3_spi_open(sck_freq_kHz, stlinkv3_handle
I did an attempt to fix error paths cleanup in CB:54190 […]
I rebased on the top of CB:54190, ready for review, should look better than before. Thanks for helping me!
-
Anastasia Klimchuk (Code Review)