Attention is currently required from: Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/83673?usp=email )
Change subject: Remove the Makefile ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Patchset:
PS2:
I found those too, and decided they didn't need to be changed. […]
Alright, I understand. manibuilder is standalone, is not the part of "building from source" process and is not much documented. Probably could be taken of at some point, but not in this patch.
Patchset:
PS3: I am thinking, maybe you can do an informational post on the mailing list with the link to the patch? It's not an ordinary patch, it's a result of a lot of work, multi-year effort! How cool is this :) I know it was on release notes, but now it's actually happening!
The main pieces of information in the post would be: link to patch and saying "we plan to submit in around 2 weeks, if all goes well". Maybe someone would want to download and run locally, I will for example. Makefile has been around for 20 years, or more even, let's give it last two weeks of goodbye!
File README.rst:
https://review.coreboot.org/c/flashrom/+/83673/comment/ced09e60_2d3f36f7?usp... : PS3, Line 28: TLDR, building with meson : """"""""""""""""""""""""" : : :: I think this is not needed as another nested header (since the other nested header gone now), and probably no need to repeat meson again. So maybe it can be
TLDR::
and then the commands?
-
Anastasia Klimchuk (Code Review)