Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58475 )
Change subject: spi25_statusreg: make register read/write functions generic ......................................................................
Patch Set 20: Code-Review+1
(2 comments)
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/58475/comment/dace9460_ac724415 PS20, Line 67: unlikley unlikely (typo)
https://review.coreboot.org/c/flashrom/+/58475/comment/fda637b6_b264ffbc PS20, Line 74: i -= 10; I can't understand this after reading the comment. The comment says only wait for initial 100ms if the register is SR1. At line 74 initial 100ms already done. Why does `i` value matter at all? The loop is expected to have only one iteration for SR1?
So just to be clear, my confusion is: why `i` value is modified, from reading the comment it seems like it doesn't matter in this case?
-
Anastasia Klimchuk (Code Review)