Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62845 )
Change subject: tests: Add padding to pci_dev struct for ASAN
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
So the test code and the programmer driver used different definitions […]
I agree that having two separate structs is not ideal. I propose that we land this patch to unblock the execution of the tests and we address the migration in a follow up patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I47943bf70181a9041f287df3ece0f7067a112de8
Gerrit-Change-Number: 62845
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 18 Mar 2022 20:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment