Change in flashrom[master]: treewide: Use calloc() where applicable - flashrom-gerrit

22 Jun 2021


      Attention is currently required from: Miklós Márton, Edward O'Callaghan, Angel Pons, Arthur Heymans.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55269 )
Change subject: treewide: Use calloc() where applicable
......................................................................
Patch Set 2:
(1 comment)
File jlink_spi.c:
https://review.coreboot.org/c/flashrom/+/55269/comment/5e4c2f46_9eff91ef 
PS2, Line 126: reverse_bytes(buffer, writearr, writecnt);
reverse_bytes used to happen before initialisation (before memset), and now happens after, because calloc inits with zeros. Does it matter?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id6ef0d6d02c7b63baabc9a0087275cab22a48736
Gerrit-Change-Number: 55269
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 22 Jun 2021 21:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment