Change in flashrom[master]: flashchips: Add Spansion/Cypress S25FL256L - flashrom-gerrit

15 Apr 2021


      Attention is currently required from: Nico Huber, Thomas Walker.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52310 )
Change subject: flashchips: Add Spansion/Cypress S25FL256L
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS1:
...
Thank you, I'm pretty new to contributing to public repositories, and this review process is a littl […]
No worries. Mistakes are a part of the learning process 😊
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/52310/comment/ef4207c9_555870cb 
PS3, Line 16380:      
nit: tabs here too (see other chips)
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4e8cba554d0590c94dac92aa91e9ab400efca281
Gerrit-Change-Number: 52310
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Walker thh.walker@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Walker thh.walker@gmail.com
Gerrit-Comment-Date: Thu, 15 Apr 2021 12:09:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Walker thh.walker@gmail.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment