Attention is currently required from: Angel Pons, Nikolai Artemiev, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61708 )
Change subject: tests: add fprintf() mock with redirection to io_mock
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61708/comment/f6836374_d53855de
PS1, Line 8:
Add comment about trying to print to avoid fd's to add context.
https://review.coreboot.org/c/flashrom/+/61708/comment/63c41b57_c656d6e3
PS1, Line 15:
trim spurious \n
--
To view, visit
https://review.coreboot.org/c/flashrom/+/61708
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f8594ea24d17436a7932732d9d05416b804dc93
Gerrit-Change-Number: 61708
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 08 Feb 2022 22:11:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment